Conversation
- Instead of passing a logger to both the Session class as well as either the CouchbaseHelper or N1ql classes, the latter two will now just use the Session's defined logger.
- In classes CouchbaseHelper ans N1ql the parameter 'logger' was ignored. To increase backwards compatability it will now be prefered, but otherwise revert to the Session's logger, or even fall back to the default logger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release PR for version 0.1.3
This is the PR which includes all changes to be included in the release of version 0.1.3.
Changes
#40 - feat:use session logger
#42 - chore:tweaked retry decorator type hint and return
WIP - Please update PR description as/is more changes are added